Slider: allow range option to be changed. Fixed #5602 - Slider Does Not ...#903
Merged
petersendidit merged 0 commit intojquery:masterfrom Feb 12, 2013
Merged
Conversation
tests/unit/slider/slider_options.js
Outdated
Member
There was a problem hiding this comment.
We're setting the disabled property on the handle? That doesn't seem correct.
Member
Author
There was a problem hiding this comment.
Yup, was doing this before my changes: https://github.com/jquery/jquery-ui/blob/master/ui/jquery.ui.slider.js#L415
Member
There was a problem hiding this comment.
That seems bad, since it's not a standard property. Can we change this test to check that the slider gets the disabled class and that dragging a handle doesn't do anything? This seems unrelated to the range changes anyway; we should pull this out into a separate PR that adds proper disable tests and remove the prop setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...Exhibit Proper Behavior When Switching Range