Skip to content

Slider: Add disabled tests and remove disabled prop from handles #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petersendidit merged 1 commit into from
Feb 4, 2013
Merged

Slider: Add disabled tests and remove disabled prop from handles #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions tests/unit/slider/slider_options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,37 @@ function handle() {

module("slider: options");

test( "disabled", function(){
expect( 8 );
var count = 0;

el = $( "#slider1" ).slider();
el.on( "slidestart", function() {
count++;
});

// enabled
ok( !el.hasClass( "ui-slider-disabled" ), "no disabled class" );
equal( el.slider( "option", "disabled" ), false , "is not disabled" );

handle().simulate( "drag", { dx: 10 } );
equal( count, 1, "slider moved");

handle().simulate("keydown", { keyCode: $.ui.keyCode.RIGHT });
equal( count, 2, "slider moved");

// disabled
el.slider( "option", "disabled", true );
ok( el.hasClass( "ui-slider-disabled" ), "has disabled class" );
equal( el.slider( "option", "disabled" ), true, "is disabled" );

handle().simulate( "drag", { dx: 10 } );
equal( count, 2, "slider did not move");

handle().simulate("keydown", { keyCode: $.ui.keyCode.RIGHT });
equal( count, 2, "slider did not move");
});

test("max", function() {
expect( 2 );
el = $("<div></div>");
Expand Down
3 changes: 0 additions & 3 deletions ui/jquery.ui.slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,9 +412,6 @@ $.widget( "ui.slider", $.ui.mouse, {
if ( value ) {
this.handles.filter( ".ui-state-focus" ).blur();
this.handles.removeClass( "ui-state-hover" );
this.handles.prop( "disabled", true );
} else {
this.handles.prop( "disabled", false );
}
break;
case "orientation":
Expand Down