Restructured if/elseif statements for better readability and removed useless variable 'focusClass'#93
Closed
thg2k wants to merge 2 commits into
Closed
Conversation
…useless variable 'focusClass'
Member
|
The focusClass isn't useless, it provides consistency with the implementation of hoverClass and allows better minification. |
Contributor
Author
|
Then why there is no activeClass (lines 50, 144, 154, 161, 165, 209 etc)? or helperHiddenClass? and what about the use of "ui-state-hover" on line 88? hoverClass has a very particular meaning, I would even rename it to "hoverClassRemover" or something like that. |
Contributor
Author
|
Ping? |
Member
|
Please reduce this to just the if statement structure. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus there is a mode change fix for tabs widget (755 -> 644)