Fixed #6859 - Jquery.Simulate drag behaves incorrect when container scrolled

[danilsomsikov]

Coordinates for mouse events are based on element offset(), which are relative to page, but events are generated in client coordinates, which are relative to window. In the case of non-zero scroll coordinates will be wrong. I suggest following patch.

[scottgonzalez]

Thanks, can you please fix the spacing? Everything is crunched together and the var statement is indented with spaces instad of tabs.

[danilsomsikov]

Is it better now? I used webinterface. Should I checkout and use normal client?

[scottgonzalez]

The indentation is better, but everything is still crunched together. For example there are no spaces around any of the operators.

[danilsomsikov]

Now I understand, sorry for this.

[scottgonzalez]

After looking into this more, I'm not sure that this patch is correct. I'm going to discuss this change with Richard Worth.

[rdworth]

Thanks for your contribution. This helped me put together a test page that I believe clearly demonstrates the problem is limited to document scroll and the fix is needed in findCenter. See http://bugs.jqueryui.com/ticket/6859#comment:4

[danilsomsikov]

Thanks you for dealing with that.

On Thu, May 26, 2011 at 12:02 PM, rdworth <
reply@reply.github.com>wrote:

Thanks for your contribution. This helped me put together a test page that
I believe clearly demonstrates the problem is limited to document scroll and
the fix is needed in findCenter. See
http://bugs.jqueryui.com/ticket/6859#comment:4

Reply to this email directly or view it on GitHub:
#94 (comment)