Skip to content

Datepicker: Remove unnecessary mouseover trigger. Fixes #5816 #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rxaviers
Copy link
Member

The first commit that introduced the mouseover trigger was 3522a23 --- side note, the short form it has now was due to 74d195e. Apparently, it addressed 3647. Although, this specific change seemed only to be a handy (yet unfortunate) way to avoid repeating code.

The two lines ran by the trigger (in the previous days and still today) are [1] and [2] below. The 1 has no effect, since such element has no ".ui-state-hover" class on creation anyway. The 2 adds ".ui-state-hover" to the target selector. But it gets removed later.

1: $(this).parents(".ui-datepicker-calendar").find("a").removeClass("ui-state-hover");
2: $(this).addClass("ui-state-hover");

Unless I'm also missing something, we could safely remove the mouseover trigger.

@jzaefferer
Copy link
Member

We should either land this soon or close it, since the rewrite won't have this problem anymore. @tjvantoll could you take a look?

@tjvantoll
Copy link
Member

I verified the problem still exists and that this fixes it. "ui-state-hover" is still managed appropriately as well. Let's land it.

@tjvantoll
Copy link
Member

fwiw here's the test case I used: http://jsfiddle.net/tj_vantoll/NqFG6/

@rxaviers rxaviers closed this in f0b4967 May 2, 2014
@jzaefferer
Copy link
Member

Okay, landed. Thanks TJ.

@jzaefferer jzaefferer deleted the fix-5816 branch May 5, 2014 14:40
@Montago
Copy link

Montago commented Jul 22, 2014

Deleting the .mouseover() trigger,. broke the Keyboard Navigation feature !!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants