Datepicker: Remove unnecessary mouseover trigger. Fixes #5816 #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We should either land this soon or close it, since the rewrite won't have this problem anymore. @tjvantoll could you take a look? |
Member
|
I verified the problem still exists and that this fixes it. |
Member
|
fwiw here's the test case I used: http://jsfiddle.net/tj_vantoll/NqFG6/ |
Member
|
Okay, landed. Thanks TJ. |
|
Deleting the .mouseover() trigger,. broke the Keyboard Navigation feature !!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit that introduced the mouseover trigger was 3522a23 --- side note, the short form it has now was due to 74d195e. Apparently, it addressed 3647. Although, this specific change seemed only to be a handy (yet unfortunate) way to avoid repeating code.
The two lines ran by the trigger (in the previous days and still today) are [1] and [2] below. The 1 has no effect, since such element has no ".ui-state-hover" class on creation anyway. The 2 adds ".ui-state-hover" to the target selector. But it gets removed later.
1: $(this).parents(".ui-datepicker-calendar").find("a").removeClass("ui-state-hover");
2: $(this).addClass("ui-state-hover");
Unless I'm also missing something, we could safely remove the mouseover trigger.