Skip to content

Missing gradients in the learn.jquery.com CSS #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgol opened this issue Jan 3, 2015 · 1 comment
Closed

Missing gradients in the learn.jquery.com CSS #335

mgol opened this issue Jan 3, 2015 · 1 comment

Comments

@mgol
Copy link
Member

mgol commented Jan 3, 2015

learn.jquery.com CSS includes many vendor prefixes for linear-gradient but it misses the most important form: the prefixless one. An example:

    background-image: -webkit-gradient(linear, left top, left bottom, from(#ffea94), to(#FFEA5E)); 
    background-image: -webkit-linear-gradient(top, #ffea94, #FFEA5E); 
    background-image:    -moz-linear-gradient(top, #ffea94, #FFEA5E); 
    background-image:     -ms-linear-gradient(top, #ffea94, #FFEA5E); 
    background-image:      -o-linear-gradient(top, #ffea94, #FFEA5E); 

from:

background-image: -webkit-gradient(linear, left top, left bottom, from(#ffea94), to(#FFEA5E));
background-image: -webkit-linear-gradient(top, #ffea94, #FFEA5E);
background-image: -moz-linear-gradient(top, #ffea94, #FFEA5E);
background-image: -ms-linear-gradient(top, #ffea94, #FFEA5E);
background-image: -o-linear-gradient(top, #ffea94, #FFEA5E);

By the way, Opera doesn't need a prefix since 12.10 (the last Presto version, current version is 26), Firefox from 16 (current version is 34); IE has never needed a prefix (only IE10 previews required one). The older WebKit gradient form also doesn't seem to be needed; the newer one is needed for the Android Browser. We only really need two forms IMO:

    background-image: -webkit-linear-gradient(top, #ffea94, #FFEA5E); 
    background-image:         linear-gradient(to bottom, #ffea94, #FFEA5E); 
@arthurvr
Copy link
Member

arthurvr commented Jan 3, 2015

Other sites do this kind of things too. Not only with gradients btw. I'il assign this to me, I'm able to fix it shortly. Update: Oh. correct. I can't assign people here

This was also the reason why I wanted to re-open #66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants