-
Notifications
You must be signed in to change notification settings - Fork 170
Upgrade to jQuery 3 #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
jQuery is loaded here in the theme: https://github.com/jquery/jquery-wp-content/blob/f9ac577/themes/jquery/header.php#L31 |
We'll need to test each site individually, and if any fail in a way that is not trivial to fix, we'll need to parameterize the jQuery version. Here is the comprehensive list:
|
jquery.org doesn't fully redirect to openjsf.org. Its home page & some other pages do but e.g. https://jquery.org/team/ is not redirected, the same applies to https://jquery.org/history/. Although, these pages look quite obsolete. Maybe we should make sure everything gets redirected and kill the site completely. |
Thanks. I didn't notice that, but I agree we can kill the site. |
The history site can be quite interesting. It stopped getting updated in 2014 and many links are dead and would have to be rewritten with Web Archive but still. |
I think if we wanted a page like that, we should just redo it static. As it's been broken for a while and not updated, I'd like to redirect and maybe add a history page later. |
All sites pass locally. The pages in demos and examples are loaded in iframes and have their own versions of jquery. I'm fairly confident we don't need to parameterize. |
Good to hear! |
I would like to point out that whatever theme the blogs are loading has an even older version of jQuery than jquery-wp-content. That could also be upgraded, but I'd need to be pointed to where those themes are. |
Nevermind, I think I found it https://github.com/jquery/blog.jquery.com-theme |
Opened jquery/blog.jquery.com-theme#6 on the blog theme |
I've run through all the staging sites and they look good to go. The only one I couldn't view was http://stage.jquerymobile.com. It's showing a 500 "Error establishing a database connection". |
Currently our sites use jQuery 1.11.3. We should switch to jQuery 3 (eating our own dogfood etc.).
cc @dmethvin @timmywil
Note that this doesn't apply to examples on various API sites which have jQuery copies versioned in repositories specific to those sites.
The text was updated successfully, but these errors were encountered: