204 select element navigation on mobile #206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture so it presents well
…arch at the 600px media query level.
…mobile navigation elements, properly get chosen to use placeholder attribute
…pacing of search form at 600 and below
|
Squashed-merged with some additional cleanup (tabs vs. spaces, quotes, making sure there is no background on nav#main between 480px and 600px at on all sites) here 7f2d8c5. Thanks @kleinmaetschke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally to a place I think is worth pushing. Been working with @ajpiano on this to get the navigation sorted out for the mobile environment. We landed on using select elements and giving those elements some style.