Skip to content

Cleaning up mistakes and invalid code. #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

kleinmaetschke
Copy link
Contributor

General clean up on a bad commit on my part from last night. Also styling for the newly edited markup conventions.

@ajpiano
Copy link
Member

ajpiano commented Feb 14, 2013

These images shouldn't be in jquery-wp-content, they're resources in jquery/jquery.org (jquery/jquery.org#31). Can you add a commit to this pull request deleting them outright.

Also, does this pull request supersede #208? Please confirm @kleinmaetschke so we can close the old one.

@kleinmaetschke
Copy link
Contributor Author

Supersedes #208, will address the images when I get to a computer.

@rdworth
Copy link
Contributor

rdworth commented Feb 14, 2013

@ajpiano in general, shouldn't the css reference images in the theme and the html content reference images in the resources directory?

@ajpiano
Copy link
Member

ajpiano commented Feb 14, 2013

Yes. The css does not reference these images, they are used as resources from the content directory, so they should be here at all.

@rdworth
Copy link
Contributor

rdworth commented Feb 14, 2013

Ok, thanks

Removing the images not referenced in CSS.
@scottgonzalez
Copy link
Member

I'm not sure if this is still relevant, but it won't merge cleanly anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants