Skip to content

Conversation

@peol
Copy link
Contributor

@peol peol commented Dec 13, 2011

I'm not sure were we stand on issues like these, but Github seems to like that you turn the autocrlf option on to avoid these issues in the future:
http://help.github.com/line-endings/

"Now that you’ve standardized the newlines in your repo things should be better. However, every person that touches your repo should turn autocrlf on, even non-Windows users. It is possible for them to bring in code from an outside source that has CRLF newlines, and you don’t want them saved into the repo like that.

For more details on the core.autocrlf setting see the git-config documentation."

@addyosmani
Copy link
Member

This looks good to me. Any other thoughts before we decide on a merge?

@peol
Copy link
Contributor Author

peol commented Dec 15, 2011

I'll see if anyone on -ot has anything to add, if not, I'll merge it tonight.

@peol
Copy link
Contributor Author

peol commented Dec 15, 2011

Just spoke to Adam, we agree'd on closing this pull request and "redo it" later. There is an issue here but having another pair of eyes on it before such a big commit would be ideal, so I didn't mess something up. :)

I also made the mistake of having this commit on my fork's master so my other pending commits are pretty screwed, I'll fix that tonight.

@peol peol closed this Dec 15, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants