Skip to content

High resolution favicon #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

High resolution favicon #302

wants to merge 3 commits into from

Conversation

nhall
Copy link

@nhall nhall commented May 13, 2014

Created a single favicon file that contains both a 32px and a 16px for high-res screens.

@nhall
High resolution favicon
ca9d520 
Created a single favicon file that contains both a `32px` and a `16px`
for high-res screens.
@scottgonzalez
Copy link
Member

Thanks, can you please update all the favicons, not just the one for api.jquery.com?

This fixes #232.

@nhall
Copy link
Author

nhall commented May 14, 2014

Yes, sir.

@nhall
Copy link
Author

nhall commented May 15, 2014

All of the favicons are updated with the exception of sizzlejs.com. Not sure the best way to handle this one as the live site doesn't look like it is using the icon in the theme on Github.

Live site favicon
Theme in Github

Is there some way to access a high quality version of whichever you prefer?

@scottgonzalez
Copy link
Member

sizzlejs.com hasn't been moved over to the new setup yet, so the live site is running off a legacy server. The icon in this repo is the correct one to work from. Just update it like the others and when the new site goes live, it'll get the correct icon. There's a zip of all the logos available at http://brand.jquery.org/resources/jquery-foundation-logos-eps.zip.

@gnarf
Copy link
Member

gnarf commented Dec 22, 2014

@nhall Did you see scott's message ealier? I'd like to land this but we need two things from you:

  • Sign the CLA with the email and full name you use for your git commits.
  • Update the sizzle favicon from the hi-res EPS pack scott mentioned.

@scottgonzalez
Copy link
Member

Closing due to inactivity. Hopefully @nhall will come back with the updates and we can reopen. If not, we do have an open issue to track this.

sigorilla added a commit to sigorilla/jquery-wp-content that referenced this pull request Mar 31, 2015
@sigorilla
All Sites: High resolution favicons
9dbc30f 
Created a favicon file for sizzlejs. Other files from PR of @nhall.

Fixes jquery#232
Ref jquery#302
@sigorilla sigorilla mentioned this pull request Mar 31, 2015
Closed
arthurvr pushed a commit that referenced this pull request Apr 22, 2015
@sigorilla @arthurvr
All Sites: High resolution favicons
6306866 
Fixes gh-232
Closes gh-351
Ref gh-302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhall @scottgonzalez @gnarf