-
Notifications
You must be signed in to change notification settings - Fork 170
Filters: Add filter for bloginfo to remove http(s) from urls. #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Make css/js urls protocol agnostic. Fixes jquerygh-312
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was an auto whitespace trim by my text editor, the blank line was there containing only a tab char.
|
This is a good start, but it's not enough to remove all the mixed protocol problems. There are other calls to |
|
There are lots of style guide violations in this code. |
mu-plugins/jquery-filters.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use ===
|
It looks like this covers everything for the CDN to work properly on HTTPS. |
mu-plugins/jquery-filters.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we can replace this with:
add_filter( 'theme_root_uri', function( $url ) {
return preg_replace( '/^https?:/', '', $url );
}, 10, 1 );Which would make the existing calls to get_*_directory_uri() use protocol-relative URLs. This would prevent us from regressing with new code.
|
So can this be merged? |
mu-plugins/jquery-filters.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shorten this to match the theme_root_uri implementation.
…tory');" This reverts commit 6751b7c. Conflicts: mu-plugins/jquery-filters.php
Fixes gh312
|
This should be the simplest form of this fix now. |
Make css/js urls protocol agnostic.
Fixes gh-312