Skip to content

Header: remove unescape call #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Header: remove unescape call #328

wants to merge 1 commit into from

Conversation

arthurvr
Copy link
Member

That unescape() isn't necessary. In h5bp it's removed too: h5bp/html5-boilerplate@cada0b6

@mgol
Copy link
Member

mgol commented Dec 21, 2014

Did you test it? You cannot use the closing </script> anywhere inside an inline script as it'll effectively close the tag prematurely.

Mathias wrote about it in a comment to the commit you linked: h5bp/html5-boilerplate@cada0b6#commitcomment-391799

@arthurvr
Copy link
Member Author

@mzgol I took a look at the current way they're doing it, and seems like that a little different too. Updated to their latest technique and tested. Sorry guys!

@gnarf
Copy link
Member

gnarf commented Dec 21, 2014

Seems alright, should we also bump to new jQuery on wp-content soon? Also, why not our own code.jquery.com cdn?

I'll let someone else come through and merge this one, I'm 👍 on it

@arthurvr
Copy link
Member Author

Seems alright, should we also bump to new jQuery on wp-content soon? Also, why not our own code.jquery.com cdn?

Yah. What browsers do we support? We can go 2.x IMHO.

@scottgonzalez
Copy link
Member

What browsers do we support?

IE8+

@arthurvr
Copy link
Member Author

Okay. Let's stay 1.x then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants