learn.jquery.com: change highlighting links #344
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sigorilla Thanks! |
|
@arthurvr I was wrong when I deleted some code in Can you reopen PR? |
|
The PR was merged, reopening it doesn't really make sense. You can create a new one with the necessary commit. |
|
@jzaefferer Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the incorrect selection active chapters in the sidebar in learn.jquery.com. For example, only
jQuery UIshould be highlighted on the pagejQuery UI, withoutWidget FactoryandUsing jQuery UI. There is same situation in other links with subchapters (Using jQuery CoreandCode Organization).This PR fixes this problem.