Skip to content

Conversation

@sigorilla
Copy link
Contributor

It is the incorrect selection active chapters in the sidebar in learn.jquery.com. For example, only jQuery UI should be highlighted on the page jQuery UI, without Widget Factory and Using jQuery UI. There is same situation in other links with subchapters (Using jQuery Core and Code Organization).

This PR fixes this problem.

@arthurvr
Copy link
Member

arthurvr commented Mar 9, 2015

@sigorilla Thanks!

@sigorilla sigorilla deleted the highlight-links branch March 9, 2015 16:47
@sigorilla sigorilla restored the highlight-links branch March 10, 2015 20:23
@sigorilla
Copy link
Contributor Author

@arthurvr I was wrong when I deleted some code in sidebar.php. It's necessary to highlight top categories (without subcategories) in the sidebar.
I made the commit (sigorilla@f90fd13), but cannot add to this PR, cause it was already closed.

Can you reopen PR?

@jzaefferer
Copy link
Member

The PR was merged, reopening it doesn't really make sense. You can create a new one with the necessary commit.

@sigorilla
Copy link
Contributor Author

@jzaefferer Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants