Fixed redirect errors (301) on 3 domains #353
Conversation
|
I'm 👍 here - thanks for doing this! |
|
@najela huge thanks for working on all these. Making all the time i put into making spider.js worth it! |
|
@arschmitz I would enjoy seeing code for the crawler which does this checks. Please where is it found? |
|
Thanks for doing this! The code for spider lives in this repo: https://github.com/arschmitz/spider.js. I'm on mobile at the moment but will merge once I get a chance. Thanks! |
|
@arthurvr Thanks for posting the link just saw this. @najela there is also a grunt task for it https://github.com/arschmitz/grunt-spider ( though i need to update the documentation for it to match latest spider.js ) |
| @@ -17,7 +17,7 @@ | |||
| * Contact | |||
| * ------------------------------------------------------- | |||
| * Email: dave@davegandy.com | |||
| * Twitter: http://twitter.com/fortaweso_me | |||
| * Twitter: https://twitter.com/fortaweso_me | |||
There was a problem hiding this comment.
We shouldn't be changing vendor files IMHO
There was a problem hiding this comment.
I buy your idea 💯/💯. Such errors will also not get noticed by jenkins
|
9567adf Solves the raised issues. I now understand why submitting a PR from your master branch is a bad idea :) |
|
@najela you don't need to worry about jenkins for errors in the 3rd party files we can configure ignore params for any of the jobs to fix things like this. Just let me know what ever needs to be ignored and ill configure it. |
This fixes the redirect errors on the links below such that
http://twitter.com* becomes **https://twitter.com
http://www.packtpub.com becomes **https://www.packtpub.com
http://www.flickr.com becomes **https://www.flickr.com
This PR is meant to fix all the present errors reported on the latest build for the http://code.jquery.com/ website