All sites: Fixes broken views #388
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix banners on plugins and events page * CSS color from uppercase to lowercase * Indention: tab, size: 4 * Delete `px` from zero values * Delete unnecessary properties * Trim all lines * Add space after colon in CSS properties
|
I've done a first pass over the changes and they look good to me. Still need to do a review of the actual rendering. |
|
Looks good to me, too. Checked the rendering with a bunch of sites locally. |
|
Go for it. I've got no objections. |
|
Closed by dace041. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone!
I fixed #373 for all window widths. Also I made very big refactoring for CSS and views:
pxfrom zero values