contribute.jquery.org: Sanitize input before rendering as HTML #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The link no longer works. |
|
Well, I suppose the consequences of submitting commit hashes containing single-quote characters (or worse) without this change are obvious. |
|
Yeah, that's true. |
|
This may only bite in combination with CLA checker bugs, right? User-provided input was already sanitized, repo/owner/sha are first used to generate |
|
I believe that's correct. |
|
OK, it shouldn't be extremely critical then. LGTM. |
0d11815 to
3aed244
Compare
|
A year and a half with no injection attacks, but I updated it anyway. 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. http://contribute.jquery.org/CLA/status/?owner=jquery&repo=jquery&sha=e217c1949f625c4c4ae7b9e93943310c73ef55ac