Skip to content

All: Fix the copy to clipboard button #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgol merged 1 commit into from
Apr 16, 2020
Merged

All: Fix the copy to clipboard button #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
All: Fix the copy to clipboard button 
The Clipboard.js library often doesn't really copy to clipboard despite
reporting it completed successfully. Instead, this commit switches from it
to a polyfill to a native clipboard async API that works (tested in Chrome 81,
Firefox 75 & Safari 13.1).

Fixes jquery/codeorigin.jquery.com#49
  • Loading branch information
@mgol
mgol committed Apr 15, 2020
commit 659c624753f98ed61a56efce3f96a2c0d1b7c505
2 changes: 1 addition & 1 deletion themes/codeorigin.jquery.com/page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
wp_enqueue_style('sri-modal', get_template_directory_uri() . '/css/sri-modal.css');

wp_enqueue_script('jquery-ui', 'https://code.jquery.com/ui/1.11.4/jquery-ui.min.js');
wp_enqueue_script('clipboard', get_template_directory_uri() . '/js/clipboard.1.5.5.min.js');
wp_enqueue_script('clipboard-polyfill', get_template_directory_uri() . '/js/clipboard-polyfill.js');
wp_enqueue_script('sri-modal', get_template_directory_uri() . '/js/sri-modal.js');
?>

Expand Down
2 changes: 2 additions & 0 deletions themes/jquery/js/clipboard-polyfill.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 0 additions & 7 deletions themes/jquery/js/clipboard.1.5.5.min.js
View file
Open in desktop

This file was deleted.

49 changes: 25 additions & 24 deletions themes/jquery/js/sri-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
$(document).ready(function() {
$( function() {
// Store modal templates
var modalTemplate = $( "#sri-modal-template" )[ 0 ].outerHTML,
clipboard;
var modalTemplate = $( "#sri-modal-template" )[ 0 ].outerHTML;

// Show modal on click
$( "body" ).on( "click", ".open-sri-modal", function( event ) {
Expand All @@ -23,32 +22,34 @@ $(document).ready(function() {
}
} );

$('.sri-modal-copy-btn').tooltip();
$('.sri-modal-copy-btn')
.tooltip()
.on( "click", function() {
var buttonElem = $( this );
clipboard
.writeText( buttonElem.attr( "data-clipboard-text" ) )
.then( function() {
buttonElem
.tooltip( "option", "content", "Copied!" )
.one( "mouseout", function() {
buttonElem.tooltip( "option", "content", "Copy to clipboard!" );
} );
} )
.catch( function() {
buttonElem
.tooltip( "option", "content", "Copying to clipboard failed!" )
.one( "mouseout", function() {
buttonElem.tooltip( "option", "content", "Copy to clipboard!" );
} );
} );
} );
event.preventDefault();
} );

// Helper functions
function replace ( string, values ) {
return string.replace( /\{\{([^}]+)}}/g, function( _, key ) {
return values[key];
});
} );
}

clipboard = new Clipboard( "[data-clipboard-text]" );

clipboard.on( "success", function( e ) {
$( e.trigger )
.tooltip( "option", "content", "Copied!" )
.one( "mouseout", function() {
$( this ).tooltip( "option", "content", "Copy to clipboard!" );
} );
} );

clipboard.on( "error", function( e ) {
$( e.trigger )
.tooltip( "option", "content", "Press Ctrl+C to copy!" )
.one( "mouseout", function() {
$( this ).tooltip( "option", "content", "Copy to clipboard!" );
} );
} );
});
} );