jquery: Fix CSS to account for the newest highlight.js #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
commented
May 20, 2021
| @@ -23,7 +23,7 @@ | |||
|
|
|||
| <link rel="shortcut icon" href="<?php echo get_stylesheet_directory_uri(); ?>/i/favicon.ico"> | |||
|
|
|||
| <link rel="stylesheet" href="<?php echo get_template_directory_uri(); ?>/css/base.css?v=2"> | |||
| <link rel="stylesheet" href="<?php echo get_template_directory_uri(); ?>/css/base.css?v=3"> | |||
There was a problem hiding this comment.
We have some caching issues so after changes it's the safest to bump this number, unfortunately...
Since for some time some sites will use an older version of `grunt-jquery-content` that includes an older highlight.js version, for now both types of CSS rules need to be present. The legacy ones have been marked with comments. The new version of highlight.js uses more generic class names, shared between languages. That means there's no 1-1 correspondence between the old & the new ones in all cases & some differences in syntax highlighting will be there. That's 9 years of highlight.js updates, though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since for some time some sites will use an older version of
grunt-jquery-contentthat includes an older highlight.js version, for now bothtypes of CSS rules need to be present. The legacy ones have been marked with
comments.
The new version of highlight.js uses more generic class names, shared between
languages. That means there's no 1-1 correspondence between the old & the new
ones in all cases & some differences in syntax highlighting will be there.
That's 9 years of highlight.js updates, though!
Ref jquery/grunt-jquery-content#81