Skip to content

Markup and styling for the plugin detail page. #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Jul 17, 2012

Conversation

ravasthi
Copy link
Contributor

@ravasthi ravasthi commented Jul 8, 2012

Sorry for the delay on this; I had some trouble getting my Windows VM setup properly to test against my Mac's Apache virtual hosts.

This code has been tested and verified to work with the latest versions of Safari, Chrome and Firefox, as well as the Retina iPad iOS simulator, and IE7, 8 and 9. Please let me know if you find any issues.

Thanks,
Richa

@ravasthi
Copy link
Contributor Author

ravasthi commented Jul 8, 2012

PS – I took some liberties with the text sizes—I don't think Helvetica is readable on-screen below 16px—but everything in what I submitted is internally consistent.

@rdworth
Copy link
Contributor

rdworth commented Jul 10, 2012

Thanks for your efforts @ravasthi . Please make the following changes:

  1. sorry I forgot to inform you we are using http://fortawesome.github.com/Font-Awesome/ so that should be used for all icons instead of images
  2. Remove any and all old-ie-specific styles. We are eventually going to address ie7+ support issues, but this work is being handled by our duo of web graphic designers (the same that have done the comps) in a way that will be consistent across all site themes. In order to minimize these work-arounds and reduce duplication, we're going to forego them entirely for the time being.

Thanks. Looking forward to the next update.

@ravasthi
Copy link
Contributor Author

Okay, great. Thanks for letting me know. I'll make those updates within the next couple of days and let you know when I'm done.

@ravasthi
Copy link
Contributor Author

@rdworth, changed as requested; please review. Thanks.

@rdworth
Copy link
Contributor

rdworth commented Jul 16, 2012

@ravasthi sorry for my delay. Just got back from being out of town for a few days. Will review. Thanks.

@ravasthi
Copy link
Contributor Author

@rdworth not a problem. Hope you had a nice trip!

I was just thinking that I neglected to ask you about coding standards and conventions. As you'll probably see from my checkin, I use spaces over tabs, 2 spaces per tab for PHP, HTML and CSS. I've got my editor set up to trim trailing spaces and convert tabs to spaces automatically. I hope that works with what you all are doing. If not, let me know and I'll change my code/settings. Thanks.

@rdworth
Copy link
Contributor

rdworth commented Jul 16, 2012

@ravasthi We use tabs, though we're far from consistent in this repo (something we should work on). Yeah, would be great if you could switch that. And also rebase as your commits will no longer merge clean on master. Thanks.

@ravasthi
Copy link
Contributor Author

@rdworth sure, I'll do that tonight and resubmit. Thanks.

@ravasthi ravasthi merged commit 87c944f into jquery:master Jul 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants