Skip to content

Add herodevs support. #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AndreAngelantoni
Copy link
Contributor

This support #462.

Within this find:

  1. add status message top of screen on homepage
  2. add Support menu item to navigation bar
  3. add warning box to API pages
  4. add styling for the above

Please note: I'm unable to confirm that #3 is in the correct theme file as we could not get the API site to work locally (two devs, two different machines). The guidelines indicate that making this guess may be acceptable.

- add status message top of screen on homepage
- add Support to navigation bar
- add warning box to api pages
- add styling for warning box
Copy link

linux-foundation-easycla bot commented Aug 26, 2024

CLA Not Signed

@mgol
Copy link
Member

mgol commented Aug 28, 2024

You'll need to sign our CLA. Follow the link from the EasyCLA bot.

@AndreAngelantoni
Copy link
Contributor Author

@mgol thanks! Shortly after submitting, Joe and I did the paperwork. We should be good to go.

Also, I'm off-grid for the next nine days. Still would be great to move this forward will I'm gone if it's easy to do so. Joe can answer questions about why I did certain things (and we aren't attached to the details).

@mgol
Copy link
Member

mgol commented Aug 30, 2024

The EasyCLA check is still red. Can you make sure the process is followed? The EasyCLA bot provided a link above. Unfortunately, that's a blocker with following up on this.

@joeeames
Copy link

joeeames commented Sep 3, 2024

ok, i just submitted a ticket. I thought I already did this...sorry

@AndreAngelantoni
Copy link
Contributor Author

AndreAngelantoni commented Sep 9, 2024

@joeeames @mgol I thought I had signed correctly last time but I did it again just now as a corporate contributor. For good measure, I signed it individually just now (and use my andre@herodevs.com email address), too.

Michael, how do you recommend we proceed? The Not Covered badge is still present yet I believe I've done what's needed.

@AndreAngelantoni
Copy link
Contributor Author

I think I figured out what's happening. The commits came in under my personal account. @joeeames I've sent a request to you but this time it will come from aangelinsf. Please approve and we should be good to go.

@mgol
Copy link
Member

mgol commented Sep 9, 2024

@AndreAngelantoni you can squash the commits into one and amend the author info, doing a git push --force-with-lease afterwards; then the check will pass.

@AndreAngelantoni
Copy link
Contributor Author

AndreAngelantoni commented Sep 11, 2024 via email

@AndreAngelantoni
Copy link
Contributor Author

Closing in favor of #467.

@AndreAngelantoni AndreAngelantoni deleted the 462-add-herodevs-support branch September 16, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants