-
Notifications
You must be signed in to change notification settings - Fork 170
Add herodevs support. #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add herodevs support. #464
Conversation
This reverts commit 74165f7.
- add status message top of screen on homepage - add Support to navigation bar - add warning box to api pages - add styling for warning box
|
You'll need to sign our CLA. Follow the link from the EasyCLA bot. |
@mgol thanks! Shortly after submitting, Joe and I did the paperwork. We should be good to go. Also, I'm off-grid for the next nine days. Still would be great to move this forward will I'm gone if it's easy to do so. Joe can answer questions about why I did certain things (and we aren't attached to the details). |
The EasyCLA check is still red. Can you make sure the process is followed? The EasyCLA bot provided a link above. Unfortunately, that's a blocker with following up on this. |
ok, i just submitted a ticket. I thought I already did this...sorry |
@joeeames @mgol I thought I had signed correctly last time but I did it again just now as a corporate contributor. For good measure, I signed it individually just now (and use my andre@herodevs.com email address), too. Michael, how do you recommend we proceed? The Not Covered badge is still present yet I believe I've done what's needed. |
I think I figured out what's happening. The commits came in under my personal account. @joeeames I've sent a request to you but this time it will come from aangelinsf. Please approve and we should be good to go. |
@AndreAngelantoni you can squash the commits into one and amend the author info, doing a |
Thanks, Michał. Timmy wants to work with me now that I'm back from vacation
so the commits may yet change.
…On Mon, Sep 9, 2024 at 3:42 PM Michał Gołębiowski-Owczarek < ***@***.***> wrote:
@AndreAngelantoni <https://github.com/AndreAngelantoni> you can squash
the commits into one and amend the author info, doing a git push
--force-with-lease afterwards; then the check will pass.
—
Reply to this email directly, view it on GitHub
<#464 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BE3WQBLGBWMMST7SAEIBNKTZVYI2TAVCNFSM6AAAAABNE7TJH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZZGIYDKMBVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Closing in favor of #467. |
This support #462.
Within this find:
Please note: I'm unable to confirm that #3 is in the correct theme file as we could not get the API site to work locally (two devs, two different machines). The guidelines indicate that making this guess may be acceptable.