Resubmitting markup/CSS for plugin detail page #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Normalize whitespace and indentation across all files in the plugins theme. * Get basic layout markup and CSS done, including fading effect for sidebar (!).
* Add normal and retina images for all icons. * Style tags and versions sections.
All that remains is the related plugins section.
With this the first pass at the plugin detail page is complete. Cross-browser testing remains.
This is so that when browsers inevitably mess up the border radius rendering of nested boxes, there's no blank spot.
* Replace icon images with Font Awesome. * Remove styles for oldIE.
|
Awesome work @ravasthi . Thank you so much. Merged. |
|
Sweet! I'm glad I was able to help a bit. Please let me know if there's something else I can help with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rdworth, I ended up having to delete and replace my fork's master branch, so I think the original pull request got deleted. Resubmitting with my changes rebased onto upstream/master. Please let me know if you see any problems.