Refactor search page to match category page. #62
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if ( preg_match('@' . $searchquery . '@i', $post->post_name) ) : |
There was a problem hiding this comment.
This is bubbling entries with names that contain the search term to the top. The new code just calls out to the content template, so we lose the sorting. @nacin is there a way to weight the sort results so that we don't need to do this?
|
Looks pretty good. |
Yes. We can do this without messing with the template. Want to merge this and I'll revisit after? |
|
rebased and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #61.
I think the category styling is specific to the category pages because the search page and category page should be using the same markup now, but they look different (I honestly haven't looked at the CSS yet).
This introduces a regression in result ordering. I'm not sure the best way to get the old behavior without duplicating the template. Perhaps with an output buffer? I'll add a line comment where the regression occurs so that everyone can see what I'm referring to.