Skip to content

Conversation

@GianlucaGuarini
Copy link

  • added SASS as default css preprocessor
  • added a README file for dummies
  • cleaner css structure
  • added a nice text shadow animation on the home page search field

- added SASS as default css preprocessor
- added a README file for dummies
- cleaner css structure
- added a nice text shadow animation on the home page search field
@danheberden
Copy link
Member

regardless of whether or not we want to do this, i noticed your diff affected every line - perhaps your editor converted the file to soft-tabs? Can you fix so that the diff shows only the lines that actually changed?

@scottgonzalez
Copy link
Member

Please start with things that are non-controversial.

@GianlucaGuarini
Copy link
Author

your editor converted the file to soft-tabs? Can you fix so that the diff shows only the lines that actually changed?

@danheberden you are right but the style.css outputted is generated by compass from the .scss files, so you should not look that file (does it really matter the indentation of a css automatically generated?) and anyway this file should never be edited! If you will decide to use a css preprocessor you have to work just on the .scss files in the sass folder.

Do we need this? I assume there is a way to generate the file without this?

@Krinkle what do you mean? Would you remove the sass folder? In that case it does not make any sense to use a CSS preprocessor because the style.css is just an output coming from that folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants