Skip to content

Use SSL by default; add option to turn it off #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Use SSL by default; add option to turn it off #1

merged 2 commits into from
Dec 29, 2023

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Dec 15, 2023

I'd like to use SSL as before, and it's more difficult to enable SSL than it is to disable it. I've reverted the change to use port 9412 without SSL by default, but I made it so it can easily be added back with one change:

.env

JQUERY_WP_HTTP_PORT=9412

This port is respected in the new wp-config.php, so no further changes required. I also made it so the virtual host for 443 is only created in apache if the certs are available in the SSL folder. I needed to keep 443:443 in the docker compose (conditionals are not possible and I don't want to have to construct the docker compose), but without certs, there's nothing listening on 443. I don't think that will be an issue for anyone, but let me know. Even if it is, however, it can be changed in the .env as JQUERY_WP_HTTPS_PORT to 0 to get some random, unused port.

@Krinkle
Copy link
Member

Krinkle commented Dec 15, 2023

I've left comments indicating the issues, but those are solvable.

Out of curiosity, what is the reason for preferring HTTPS locally? Does it allow better testing of certain pages?

@timmywil
Copy link
Member Author

timmywil commented Dec 15, 2023

Out of curiosity, what is the reason for preferring HTTPS locally?

We talked about it a bit in chat. Essentially, my security settings (mainly my VPN), make it difficult to allow non-https anywhere but localhost. The settings are admittedly aggressive, but it's easier to support it here than it is for me to change it. Also, there are advantages to being able to test these sites locally with https. In the immediate future, it will come in handy when testing CSP changes.

Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm setting JQUERY_WP_HTTP_PORT works so I have no further reservations against this PR.

- also fix the apache host for when certs are not provided
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants