Use SSL by default; add option to turn it off #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to use SSL as before, and it's more difficult to enable SSL than it is to disable it. I've reverted the change to use port
9412
without SSL by default, but I made it so it can easily be added back with one change:.env
This port is respected in the new
wp-config.php
, so no further changes required. I also made it so the virtual host for 443 is only created in apache if the certs are available in the SSL folder. I needed to keep443:443
in the docker compose (conditionals are not possible and I don't want to have to construct the docker compose), but without certs, there's nothing listening on 443. I don't think that will be an issue for anyone, but let me know. Even if it is, however, it can be changed in the .env asJQUERY_WP_HTTPS_PORT
to0
to get some random, unused port.