Use https for download links

[dmethvin]

Right now we use http for downloading even if the user came in via https. Now that the CDN supports https we should use it, at the very least when the user comes in via a secure connection, by removing the protocol from all the downloady links.

[arschmitz]

Why don't we just use protocol relative links like we do everywhere else?

Thats also what the google cdn does

[dmethvin]

We can do that. Some people might make the case that we should always serve out the files via https though, even if they came in via http. Thoughts?

[arschmitz]

For reference how different cdn's display by default
Google - relative
Microsoft - http ( no link at all to https but it works )
cdnjs - https ( but when you click copy it gives you option )
bootstrapcdn - relative
jsdelivr - relative
and last our own cdn is relative

[fabiosantoscode]

Protocol relative links don't work so well under file:// ...

[mgol]

What's the use-case of relative protocol urls at this date, by the way?
What's the drawback of just using https everywhere?

Michał Gołębiowski

[dmethvin]

I don't think file:// would be a problem for this case. I'm fine with relative links, or https.

[arthurvr]

These days protocol-relative URLs is totally anti-pattern indeed. We recently switched everything over in HTML5 boilerplate as well. I'm 👍 for https always.

[mgol]

It seems everyone is in favor. We even have a PR: #116. Can we rebase & land it?

[AurelioDeRosa]

@mgol If you want I can take care of the PR. Let me know.

[mgol]

Sure, I'll handle it.

[AurelioDeRosa]

@mgol I've just realized that probably there is nothing I should do other than asking the user to rebase. If the user won't do it, then I can take an action. Do you agree?

[mgol]

Sure.