Skip to content

Download: Add subresource integrity to CDN examples #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Download: Add subresource integrity to CDN examples #112

wants to merge 1 commit into from

Conversation

kborchers
Copy link
Member

We also need to add the hashes for people to use to code.jquery.com which is being tracked in jquery/codeorigin.jquery.com#20 and should add this where ever it makes sense on other project sites referring to using the CDN

@mgol
Copy link
Member

mgol commented Nov 2, 2015

Looks good, it'd be nice to have it described how to generate those for the sake of future releases. This instruction should be linked to from https://github.com/jquery/jquery/wiki/Release-process.

@scottgonzalez
Copy link
Member

We shouldn't need to manually generate these during releases though. The CDN repo should be generating these and displaying them as part of jquery/codeorigin.jquery.com#20. You'll just need to copy and paste the values as part of the release when you update the URLs on the download page.

dmethvin added a commit that referenced this pull request Apr 14, 2016
@dmethvin
Copy link
Member

What I did instead in c869920 was remove the script tag entirely and point people over to the CDN to get the tags with SRI included. That way we don't need to maintain that info here, and people can get the SRI tag for any version not just the current one. I am pretty sure that people would have tried copying the tag verbatim from this page and then editing the file version with bad results, because people.

@dmethvin dmethvin closed this Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants