Download: Add a "Downloading jQuery using npm" section#123
Merged
mgol merged 1 commit intojquery:jquery-3from Mar 14, 2016
Merged
Download: Add a "Downloading jQuery using npm" section#123mgol merged 1 commit intojquery:jquery-3from
mgol merged 1 commit intojquery:jquery-3from
Conversation
pages/download.md
Outdated
| ``` | ||
| npm install jquery | ||
| ``` | ||
| This will install jQuery to the `node_modules` directory. Within `node_modules/jquery/dist/` you will find an uncompressed release, a compressed release, and a map file. |
Member
There was a problem hiding this comment.
Perhaps "to the node_modules directory"?
Member
Author
There was a problem hiding this comment.
Isn't that what I've written?
Member
There was a problem hiding this comment.
Oh dear, I meant "in the node_modules directory"
Member
|
Apart from my minor comment, the PR LGTM. |
8b34830 to
23a77ea
Compare
mgol
added a commit
that referenced
this pull request
Mar 30, 2016
mgol
added a commit
that referenced
this pull request
Mar 30, 2016
mgol
added a commit
that referenced
this pull request
Mar 31, 2016
mgol
added a commit
that referenced
this pull request
Apr 25, 2016
mgol
added a commit
that referenced
this pull request
May 9, 2016
mgol
added a commit
that referenced
this pull request
May 20, 2016
mgol
added a commit
that referenced
this pull request
May 21, 2016
timmywil
pushed a commit
that referenced
this pull request
Jun 9, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122
Screenshot:
The Bower section looks really similar now; perhaps we should simplify it now that it's not a recommended way to get jQuery? We could change it to a simple mention and redirect people to Bower docs for more info (e.g. target directory). Thoughts?