Skip to content

Docs: Describe jQuery.when split paths#129

Closed
gibson042 wants to merge 2 commits intojquery:masterfrom
gibson042:3.0-when-arguments
Closed

Docs: Describe jQuery.when split paths#129
gibson042 wants to merge 2 commits intojquery:masterfrom
gibson042:3.0-when-arguments

Conversation

@gibson042
Copy link
Member

As of jQuery 3.0, both of these return a new Deferred (previous versions did not create a new Deferred when called with a single Deferred input).

https://github.com/jquery/jquery/issues/2710
https://github.com/jquery/jquery/issues/2018
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these have two spaces after them to create a line break? I can't tell.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I didn't realize why they were present until their removal borked the GitHub rich diff.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah and they call html markup obscure. 😈 Another option would be to put them all on one line but turn them into links, something like Related: gh-1234, gh-2345. That could all be reformatted in a later pass though.

@gibson042 gibson042 closed this in a7e19f7 May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants