Skip to content

Index: Add a no support notice for 1.x/2.x versions under Download #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2017

Conversation

mgol
Copy link
Member

@mgol mgol commented Jul 5, 2017

I also commited the generated package-lock.json. Any thoughts about that, @jquery/content?

This needs to be reviewed/landed together with jquery/jquery-wp-content#405.

Screenshot:
screen shot 2017-07-05 at 13 39 39

@kswedberg
Copy link
Member

@mgol package-lock.json seems fine with me. That doesn't require everyone to upgrade to node 8 / npm 5, does it?

@mgol
Copy link
Member Author

mgol commented Jul 5, 2017

To use it, no, but if someone wants to upgrade a package or install a new one, npm 5 is required as otherwise package.json would de-synchronize with the lock file.

@kswedberg
Copy link
Member

right, okay. Seems like a good idea to me!

@mgol mgol merged commit 0b492bb into jquery:master Jul 26, 2017
@mgol mgol deleted the no-support-message branch July 26, 2017 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants