Skip to content

Upgrade: add 4.0 upgrade guide #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2025
Merged

Upgrade: add 4.0 upgrade guide #250

merged 6 commits into from
May 12, 2025

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Mar 31, 2025

  • Also update node dependencies (I did this so I could test locally)

Fixes jquery/jquery#5365

@timmywil timmywil requested review from mgol and gibson042 March 31, 2025 15:14
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good first draft! I added some comments.

@timmywil timmywil requested a review from mgol April 28, 2025 15:06
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more comments. Thanks!

@timmywil timmywil requested a review from mgol May 5, 2025 15:46
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, but LGTM otherwise. Good work!

This has been renamed since 3.7.0 to jQuery.Deferred.getErrorHook. It is used to pass the original error to jQuery.Deferred.exceptionHook. Previously, we recommended passing the stack but that didn't play well with source maps.
This has been renamed since 3.7.0 to `jQuery.Deferred.getErrorHook`. It is used to pass the original error to `jQuery.Deferred.exceptionHook`. Previously, we recommended passing the stack but that didn't play well with source maps. `jQuery.Deferred.exceptionHook` can be used to debug asynchronous errors.

TODO: link to documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timmywil timmywil merged commit 18dd487 into jquery:main May 12, 2025
1 check passed
@timmywil timmywil deleted the upgrade branch May 12, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Prepare a 4.0 upgrade guide
2 participants