-
Notifications
You must be signed in to change notification settings - Fork 97
Added instructions for downloading with Bower #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an odd thing for us to document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documented this at the request of @dmethvin in PR jquery/jquery/pull/1542. The idea being that this may cut down on the volume of complaints concerning the amount of files downloaded when requesting the jQuery package through Bower.
What's the reason for it being "odd"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where he asked for this. Can you point to the specific comment?
Are there any other projects telling people how to use Bower to install arbitrary files instead of actual packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmethvin asked here: jquery/jquery#1542 (comment)
I don't know off hand if any other projects mention doing this but installing an arbitrary file instead of an actual package is described here: http://bower.io/#installing-packages-and-dependencies, in the last bullet point under "Where
<package>can be any one of the following"This obviously isn't the best way to install jQuery but according to what @dmethvin has said, there seems to be a number of people who for one reason or another have a problem with getting more than just
jquery.jsfrom the Bower package. This update the documentation is attempting to highlight an alternative in case they didn't think of it on their own.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ornj I don't know whether you PR will land nor can I influence in any way. However, if it is accepted it would be great if you could fix a small typo: on it's own -> on its own. Thanks :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always mess that up. I think someone else is going to work on this but thanks for the copy edit.