Skip to content

issue#19 fix#95

Closed
ashg1910 wants to merge 1 commit intojquery:masterfrom
ashg1910:issuefix
Closed

issue#19 fix#95
ashg1910 wants to merge 1 commit intojquery:masterfrom
ashg1910:issuefix

Conversation

@ashg1910
Copy link

@ashg1910 ashg1910 commented Apr 5, 2015

CLA signed

@arthurvr
Copy link
Member

arthurvr commented Apr 6, 2015

@ashg1910 This is your 4th PR for the same issue. Could you please just update your PR next time? Having multiple PRs for the same thing does not make sense and just makes things difficult and noisy.

@ashg1910
Copy link
Author

ashg1910 commented Apr 6, 2015

@arthurvr I needed to send the PR again in order to make it CLA signed.
sorry for the inconvenience caused

@arthurvr
Copy link
Member

arthurvr commented Apr 6, 2015

I needed to send the PR again in order to make it CLA signed.

As you can read on the page we linked to you can just update your PR.

@arthurvr
Copy link
Member

As @rxaviers wrote in one of your earlier PRs, I don't think a <div> surrounded by an <a> is a good idea.

@ashg1910
Copy link
Author

@arthurvr I guess its okay for html5 - http://stackoverflow.com/questions/1827965/is-putting-a-div-inside-an-anchor-ever-correct
will try another fix if this isn't right

@mgol
Copy link
Member

mgol commented Nov 16, 2015

IMO it looks good since HTML 5 allows it. Any objections to just land it? @arthurvr, @jzaefferer?

@kswedberg
Copy link
Member

It's fine according to HTML5 spec, but there should probably be something in the stylesheet along the lines of:

.project-tiles a {
  display: block;
}

@mgol
Copy link
Member

mgol commented Feb 14, 2018

@ashg1910 I've tested it but it doesn't look like the original. The logos are aligned incorrectly etc. Have you tested it locally? If so, can you make the changes that will preserve the current layout? If not, please also write that so that we know.

We'll also need you to sign our new JS Foundation CLA, the old jQuery Foundation one no longer applies.

@mgol
Copy link
Member

mgol commented Feb 14, 2018

@ashg1910 Sorry, I've seen jquery/jquery-wp-content#356 only now. Can you sign the CLA and rebase both PRs? I'd land them then.

@mgol
Copy link
Member

mgol commented Mar 21, 2018

@ashg1910 ping?

@mgol
Copy link
Member

mgol commented Jun 13, 2018

Per lack of response I'm closing this in favor of jquery/jquery-wp-content#413 & #177.

@mgol mgol closed this Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants