Conversation
|
@ashg1910 This is your 4th PR for the same issue. Could you please just update your PR next time? Having multiple PRs for the same thing does not make sense and just makes things difficult and noisy. |
|
@arthurvr I needed to send the PR again in order to make it CLA signed. |
As you can read on the page we linked to you can just update your PR. |
|
As @rxaviers wrote in one of your earlier PRs, I don't think a |
|
@arthurvr I guess its okay for html5 - http://stackoverflow.com/questions/1827965/is-putting-a-div-inside-an-anchor-ever-correct |
|
IMO it looks good since HTML 5 allows it. Any objections to just land it? @arthurvr, @jzaefferer? |
|
It's fine according to HTML5 spec, but there should probably be something in the stylesheet along the lines of: .project-tiles a {
display: block;
} |
|
@ashg1910 I've tested it but it doesn't look like the original. The logos are aligned incorrectly etc. Have you tested it locally? If so, can you make the changes that will preserve the current layout? If not, please also write that so that we know. We'll also need you to sign our new JS Foundation CLA, the old jQuery Foundation one no longer applies. |
|
@ashg1910 Sorry, I've seen jquery/jquery-wp-content#356 only now. Can you sign the CLA and rebase both PRs? I'd land them then. |
|
@ashg1910 ping? |
|
Per lack of response I'm closing this in favor of jquery/jquery-wp-content#413 & #177. |
CLA signed