-
Notifications
You must be signed in to change notification settings - Fork 20.6k
Release: Error in Sizzle version check #1939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't think it likes the version number. However, I'm not sure you'll encounter the same problem on master/compat since we dropped bower. |
Oh, I understand. You won't encounter this problem on master/compat because the Sizzle version there is not funky. |
rversion didn't match so it's passing null. I'll do a fix, but it won't matter. |
If that occurs would it be considered an error? |
I suppose it would be right now, but it might not be in the future. |
That is, if we were to publish a version of Sizzle to npm that does not exactly fit the format of x.x.x-optionalWord. |
Dies during the check, not sure why. I just backed out 1d93106 fon 1.11-stable and 2.1-stable, but we'll need to to the same or fix it before 3.0 in both master and compat.
The text was updated successfully, but these errors were encountered: