Fix for #7371: prevent Content Security Policy inline-script violations #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icy inline-script violations from occuring. Fixes #7371.
…rity Policy inline-script violations from occuring. Fixes #7371." Going to make a new patch that leaves most of the changes in support.js. This reverts commit 6ae572f.
…event Content Security Policy inline-script violations. Fixes #7371
This reverts commit 5e90cce.
… by this. I mistakenly thought I had pushed the old patch. This is the correct patch to fix #7371.
Member
|
Closing after no response from submitter in 30 days. |
Member
|
Landed. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a better fix for #7371 than the previous attempt, as it leaves the vast majority of changes in support.js.
This patch defers the scriptEval test until the first time that globalEval is called. This prevents Content Security Policy from causing inline-script violations. All unit tests are passing with the patch applied.