JSHint: Make compatible with jshint, lint test/data, clean up jshintrc files#1043
JSHint: Make compatible with jshint, lint test/data, clean up jshintrc files#1043Krinkle wants to merge 1 commit intojquery:masterfrom Krinkle:grunt-lint
Conversation
|
@Krinkle can you rebase this? I tried doing it myself but I'm not sure I understand all the changes and it's giving quite a few errors after the merge. |
The "options" and "globals" properties are grunt-jshint specific. Which means running node-jshint from cli, or using an editor with jshint/jshintrc support would not read any of the options and thus blow the editor full of errors (based on the default options in jshint core). Alphabetised the options again and separated the individual groups with a line break (restriction, laxing, environment). Especially because restriction is true-to-restrict, and laxing is true-to-lax. Mixed was somewhat confusing. Removed laxing options and globals that were no longer used. Added a .jshintignore file to make sure that it actually passes properly.
|
Failures in ajax.js and offset.js are also occurring in latest master. |
|
I only see offset.js failures in IE8 for master. |
|
@jaubourg: The ajax.js failures show up at random, there are some issues with jQuery's ajax test suite (fails at random in Chrome). If you take another look at the TestSwarm job page linked from the Mergeatron (http://swarm.jquery.org/job/1703) the Chrome failure fixed itself on the second try. |
|
Okay, so i want to either close or land this. Again it's conflicted. |
|
There is 1 test failure (http://swarm.jquery.org/job/1703) which is not related to this PR and is happening on all master commits and PRs. As far as I'm concerned it can be landed. |
|
@Krinkle, it doesn't merge cleanly. Please rebase. |
|
That's because 228ab3d changes those files again. I've asked that commit to be reverted (not because it makes this PR not merge cleanly, but for other reasons). I can rebase if need be, but assuming 228ab3d will be reverted before this is merged, I won't rebase since after that revert, it will have to be rebased, again to how it is now. Wasted effort. |
No description provided.