Merged
Conversation
Member
|
This change caused the serialize tests to fail, backed out. |
Member
Author
|
Fixed the failing tests in IE, which it turns out were flaws in the |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5566 and #6997 are both facets of the same issue: creating an element with event handlers without attaching it to the page, then calling a domManip function that clones and appends the fragment in multiple places, causes the event handlers to disappear. This patch ensures that event handlers are cloned properly as well.
This pull request also includes a separate commit nuking excess whitespace from manipulation.js, because my text editor kindly did that automatically for me at the same time.