Fixes #7762: unload cleanup is called on IE7, IE8, but should be only on IE6 #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ve confirmed that there is no inter-page leaking in currently supported versions of IE6, so I am closing this pull request and opened a new one, #149 |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition is already a hidden sniffing: "window.attachEvent && !window.addEventListener" sniffs for IE assuming that any IE leak, but that's not true. Only IE6 does.
On IE7 that may be visible as sluggishness and CPU load when leaving a page with many handlers on slow PC.
I added a check for non-existance of native XHR to ensure that only IE6 gets the code execute, so IE7, IE8 users don't execute the unnecessary code.