Attributes: Use the option val hook in select val hook and simplify it #1901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmethvin Should I create an issue for that first for changelog purposes? I guess labels would then be dropped from this PR. |
|
Seems like that would make the changelog better, so yeah let's do it. |
40e70bd to
c97d8ea
Compare
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Dec 4, 2014
The hook is still defined; not using it could cause issues in IE<11. Also, IE10 no longer throws when value not set but it still doesn't trim the value. IE11 has all those issues fixed; support comments are updated. Fixes jquerygh-1902 Closes jquerygh-1901
|
LGTM |
|
👍 |
|
If tests are passing, then LGTM |
The hook is still defined; not using it could cause issues in IE<11. Also, IE10 no longer throws when value not set but it still doesn't trim the value. IE11 has all those issues fixed; support comments are updated. Fixes jquerygh-1902 Closes jquerygh-1901
c97d8ea to
f6302b0
Compare
mgol
added a commit
that referenced
this pull request
Dec 8, 2014
The hook is still defined; not using it could cause issues in IE<11. Backport the test from the master branch. Also, IE10 no longer throws when value not set but it still doesn't trim the value. IE11 has all those issues fixed; support comments are updated. (cherry-picked from f6302b0) Fixes gh-1902 Closes gh-1901
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hook is still defined; not using it could cause issues in IE<11.
Also, IE10 no longer throws when value not set but it still doesn't trim the
value. IE11 has all those issues fixed; support comments are updated.
Fixes gh-1902
Closes gh-1901
Most of this PR will need to be cherry-picked to
compatas well.Funny what things you find when you remove support for older browsers. ;)