Tests: fix cross-domain detection test for non-default port

[victor-homyakov]

Tests: fix cross-domain detection test for non-default port

[dmethvin]

Can you add a unit test?

[victor-homyakov]

Add a test that another test passes?

[victor-homyakov]

This PR fixes an AJAX test which was properly passing only with default (80) port (when location.host === location.hostname) and failing when running on non-default (thus not omitted from host) port.

[dmethvin]

OK, so that makes the unit test a bit hard. We'd need to make a request to a non-default port and we don't have a test server running there.

N.B. We'll need an issue describing the problem.

[victor-homyakov]

No. Suppose you have your test server installed on 8080 port. In this case test will fail because URL string will look like http://localhost:8080:8080 because of host + port wrongly used instead of hostname + port.

[dmethvin]

Right, so if we want to test both port 80 and port 8080 to ensure that both work, i was thinking we'd need two servers. But really we can just make the request, let it massage the URL, inspect the result, and cancel it before the request. Does that make sense? We need a unit test to do that.

[victor-homyakov]

One line of code is worth thousand words. Just show how this test will look like and what it will actually check. I think we cannot test cross-origin detection for 8080 port without test page actually running on that port.

[victor-homyakov]

Ping?

[dmethvin]

Sorry, I lost track of this. Looking at it with fresh eyes, I now realize what you are saying! The change is only in the unit test so I'm good with landing it as-is.