#2773 - $.fn.is to accept jQuery and node objects#206
Merged
jeresig merged 4 commits intojquery:masterfrom Apr 10, 2011
Merged
Conversation
added 4 commits
January 24, 2011 16:18
…and a small fix for winnow getting an undefined selector
….fn.not (should have no effect on existing object rather than return an empty object as filter does)
Contributor
|
on jsperf there is a second revision of this patch (dont know if you merged v1 or v2 of the patch) in case you merged revision2... v2 runs into problems on FF4 (winxp), see http://jsperf.com/jquery-fn-is/2 TypeError: c.replace is not a function. TypeError: c.replace is not a function. |
Member
Author
|
That perf is probably stale. If you could reproduce an issue on jsfiddle.net using jquery(edge), please submit to bugs.jquery.com. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See new traversing.js tests. It does seem the performance is in line and it is safe to say there is no loss.
Performance tests: http://jsperf.com/jquery-fn-is
http://bugs.jquery.com/ticket/2773
http://bugs.jquery.com/ticket/8609 (both filter and not now return an empty selection on any invalid argument)