Skip to content

Conversation

@dracos
Copy link

@dracos dracos commented Jan 13, 2016

This is a copy of @timmywil's commit, applied to the 1.x branch. This shouldn't have any effect on the extra browsers 1.x supports due to the doScroll check, so I was hoping it could be added in order to provide the same benefit to other browsers as that commit :)

Fixes gh-2822

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @timmywil, @markelog and @mgol to be potential reviewers

@dmethvin
Copy link
Member

Oh yeah, seems like we missed this one. 1.12 and 2.2 should definitely behave the same here.

@timmywil
Copy link
Member

Needs the test that was added as well. dabd5ba

@timmywil
Copy link
Member

But I agree. Thanks for finding this!

@dmethvin
Copy link
Member

It would be better to cherry pick the change if possible, just to simplify auditing.

@dracos
Copy link
Author

dracos commented Jan 13, 2016

"It would be better to cherry pick the change if possible, just to simplify auditing." - happy to do this, though it will need editing the 'Support' line - would you prefer that be done by editing the commit, or a second commit afterwards?
Oh, and the commit message itself too.

@timmywil
Copy link
Member

Editing the commit should be fine.

@timmywil
Copy link
Member

Thanks! Merged.

@timmywil timmywil closed this Jan 14, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants