Selector: Drop support for EdgeHTML (i.e. non-Chromium Microsoft Edge) #4573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
commented
Dec 16, 2019
| @@ -542,7 +542,7 @@ jQuery.extend( { | |||
| if ( s.crossDomain == null ) { | |||
| urlAnchor = document.createElement( "a" ); | |||
|
|
|||
| // Support: IE <=8 - 11+, Edge 12 - 17 only | |||
| // Support: IE <=8 - 11+ | |||
There was a problem hiding this comment.
I removed mentions of Edge from support comments as well. Among other things, this is because many IE workarounds are now hidden behind an isIE check so a support comment mentioning Edge would be confusing as Edge wouldn't execute that code.
IE is quite special here as that's the only browser which we detect as a browser to work around its bugs instead of running support tests.
Also, restrict some workarounds that were applied unconditionally in all browsers to run only in IE now. This slightly increases the size but reduces the performance burden on modern browsers that don't need the workarounds. Also, clean up some comments & remove some obsolete workarounds. Fixes jquerygh-4568
|
Closing for now until we really plan to do it. |
|
New PR: #4792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NOTE: This is a draft PR. No decision has been made yet.
Also, restrict some workarounds that were applied unconditionally in all
browsers to run only in IE now. This slightly increases the size but reduces
the performance burden on modern browsers that don't need the workarounds.
Also, clean up some comments & remove some obsolete workarounds.
Fixes gh-4568
-240 bytes
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com