Adds a due diligence check for pre-defined data-* attrs during removal. Fixes #10026 #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If we're going to keep |
Member
Author
|
@dmethvin I'm mobile right now, when I get back to the office lets rap about this, because the hasData ticket at 10027 has me second guessing this patch now. |
Member
|
Landed in commit 6805fc2. |
Member
|
Ugh. Please revert this pull request. http://bugs.jquery.com/ticket/10113#comment:2 |
mescoda
pushed a commit
to mescoda/jquery
that referenced
this pull request
Nov 4, 2014
…data-* attrs during removal. Fixes #10026. More Details: - jquery#461 - http://bugs.jquery.com/ticket/10026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://bugs.jquery.com/ticket/10026