1.7 - queue refactoring to handle delay stop - Fixes #6150#514
Closed
gnarf wants to merge 2 commits intojquery:masterfrom
Closed
1.7 - queue refactoring to handle delay stop - Fixes #6150#514gnarf wants to merge 2 commits intojquery:masterfrom
gnarf wants to merge 2 commits intojquery:masterfrom
Conversation
Member
|
Seems like the scope for this crept beyond the bugfix that seemed to be in 6150. Is there a simpler fix for the reported bug? I am wondering if this might be best to tackle with the 1.8 event refactoring. |
Member
Author
|
It did creep beyond, but the "beyond" part is mostly handling multiple queues in stop. I figured since I added multiple animate queues, this might be needed now. The default for stop is to stop all animates. The code for the "creep" part of it is really only part of two if statements, and one assignment. |
Member
|
Well darn, I was hoping that we'd be able to save some bytes. |
Member
|
Landed in commit a3b59d7. |
mescoda
pushed a commit
to mescoda/jquery
that referenced
this pull request
Nov 4, 2014
…p - Fixes #6150. More Details: - jquery#514 - http://bugs.jquery.com/ticket/6150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a second parameter passed to .queue functions. This parameter points at a private data object. Setting a
stopproperty to be a function on this parameter will add a hook for the.stop()call to get passed along.Also adds support for
.stop()on a single queue as opposed to all queues. If we decide to turn down the stop hooks, the single queue option for.stop()might still want to be investigated. Now that.animate()can work in multiple queues, it might be nice to stop only one of them.