Attributes: Shave off a couple of bytes #5398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
attrHooksentries for boolean attributes are only defined for jQuery 4+; jQuery 3.x used a separate mechanism - assigning them tojQuery.expr.attrHandle. That object used to be maintained by Sizzle, since jQuery 3.7.0 it's kept in the selector module. Because of that, theisXMLDoccheck used to be require in this hook.Now that standard
attrHooksare used, theisXMLDoccheck already happens inside ofjQuery.attrand there's no need to repeat it in the test. Note that this repetition is even incorrect - while Sizzle'sjQuery.find.attrused to treat anundefinedoutput of the hooks fromjQuery.expr.attrHandleas a way to opt out of the hook, jQuery'sattrHooksusenullto opt out of a getter hook.Apart from the size, this patch also avoids unnecessary extra checks.
Size difference:
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com