Skip to content

Tests: Use releases.jquery.com as external host for AJAX testing#5688

Merged
mgol merged 1 commit intojquery:mainfrom
mgol:ajax-external-host
Aug 11, 2025
Merged

Tests: Use releases.jquery.com as external host for AJAX testing#5688
mgol merged 1 commit intojquery:mainfrom
mgol:ajax-external-host

Conversation

@mgol
Copy link
Member

@mgol mgol commented Aug 6, 2025

Summary

Previously, we used example.com. However, that one is rate-limited, causing us frequent unit test failures.

Checklist

Previously, we used example.com. However, that one is rate-limited, causing us
frequent unit test failures.
@mgol mgol added this to the 3.8.0 milestone Aug 6, 2025
@mgol mgol requested a review from timmywil August 6, 2025 16:45
@mgol mgol self-assigned this Aug 6, 2025

// see RFC 2606
this.externalHost = "example.com";
this.externalHost = "releases.jquery.com";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this will trigger a request to https://releases.jquery.com on every AJAX test run. But it's served by Fastly and the traffic will be waaay lower than the normal CDN one, so I hope we're fine. Thoughts, @Krinkle?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, yeah.


// see RFC 2606
this.externalHost = "example.com";
this.externalHost = "releases.jquery.com";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, yeah.

@mgol mgol merged commit f21a6ea into jquery:main Aug 11, 2025
17 checks passed
@mgol mgol deleted the ajax-external-host branch August 11, 2025 15:43
@mgol mgol modified the milestones: 3.8.0, 4.0.0 Aug 11, 2025
mgol added a commit that referenced this pull request Aug 11, 2025
Previously, we used example.com. However, that one is rate-limited, causing us
frequent unit test failures.

Closes gh-5688

(cherry picked from commit f21a6ea)
@mgol mgol modified the milestones: 4.0.0, 3.8.0 Aug 11, 2025
@mgol mgol removed the Needs review label Aug 11, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants