fixes #10691, remove all instances of equals() and same() in unit tests#580
Closed
mikesherov wants to merge 1 commit intojquery:masterfrom
Closed
fixes #10691, remove all instances of equals() and same() in unit tests#580mikesherov wants to merge 1 commit intojquery:masterfrom
mikesherov wants to merge 1 commit intojquery:masterfrom
Conversation
…re deprecated in QUnit
Member
|
Landed. f35ba5e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10691, remove all instances of equals() and same(), as these are deprecated in QUnit.
A big PR, I know, but I've tested this a few times, and it is relatively harmless, and I'll do another sweep in a few weeks to catch any other PR's that get in that use these functions.
Also, if any PR's get in that DO use equals() or same(), QUnit already has a backup of these functions, so the backwars compat stuff in testrunner.js was unnecessary anyway and won't cause tests to break.