Check if selector is not typeof string _and_ not null before reassigning arg values when on(event-map [, selector][, data]). Fixes #11130#652
Closed
rwaldron wants to merge 2 commits intojquery:masterfrom
Closed
Conversation
…ing arg values when on(event-map [, selector][, data]). fixes #11130
src/event.js
Outdated
Contributor
There was a problem hiding this comment.
intended non-strict check here?
don't know if performance matters, but shouldn't it be faster to check for null first?
Member
Author
There was a problem hiding this comment.
non-strict b/c strict === null breaks bind/unbind/one with data behaviour
The non-coerced typeof check is probably faster, but likely not to a statistically significant degree
Member
|
Landed. c0da49f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For review.
See: http://bugs.jquery.com/ticket/11130