Support for relative values for $().css setters (#7345)#78
Closed
brandonaaron wants to merge 1 commit intojquery:masterfrom
brandonaaron:7345
Closed
Support for relative values for $().css setters (#7345)#78brandonaaron wants to merge 1 commit intojquery:masterfrom brandonaaron:7345
brandonaaron wants to merge 1 commit intojquery:masterfrom
brandonaaron:7345
Conversation
Member
|
Is there a way this could be combined with the pre-existing code in effects.js instead of copy-pasting duplicate code? |
Member
|
Closing after 30 days of no response from submitter. |
|
Just a thought to get rid of that (parts[1] === "-=" ? -1 : 1) test... change regex: css.js and possibly... effects.js |
Member
|
A newer version of this pull req can be found at #297 - Changed the way it parses the string and wrote some improved tests. |
krunkosaurus
pushed a commit
to krunkosaurus/jquery
that referenced
this pull request
Apr 20, 2011
…odified from original pull req by brandonaron jquery#78
markelog
pushed a commit
to markelog/jquery
that referenced
this pull request
Aug 9, 2011
…odified from original pull req by brandonaron jquery#78
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for ticket #7345. Supporting +=/-= for setting values in $().css.
We might want to share the rrelnum regex with the rfxnum regex from effects.js since they are the same.
Also, this patch doesn't really take other units than pixels into consideration.